Bump tusd to v2.4.0 #4784
Merged
Bump tusd to v2.4.0 #4784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
Full-ci ocis pipeline is green: owncloud/ocis#9714 |
|
If I understand correctly we also have to implement the Unwrap interface otherwise we getting warnings regarding NetworkControlError/NetworkTimeoutError and "feature not supported" |
dragonchaser
previously requested changes
Jul 31, 2024
Signed-off-by: jkoberg <jkoberg@owncloud.com>
Correct, but we are passing a noop logger (with did that before too). Hence we will not see those error messages. |
fschade
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps tusd to v2.4.0 to enable tackling owncloud/ocis#1755