Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix micro ocdav service #4774

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Conversation

butonic
Copy link
Contributor

@butonic butonic commented Jul 22, 2024

We no longer call Init to configure default options because it was replacing the existing options.

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic requested review from labkode, glpatcern and a team as code owners July 22, 2024 09:06
@butonic butonic self-assigned this Jul 22, 2024
Copy link
Contributor

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@phil-davis
Copy link
Contributor

Is this fix related to owncloud/ocis#9659 ?
(where test pipelines had a problem related to ocdav)

@kobergj
Copy link
Contributor

kobergj commented Jul 22, 2024

Yes. This should fix all pipelines that failed with

{
  "level": "error",
  "service": "com.owncloud.web.ocdav",
  "error": "not found",
  "time": "2024-07-22T00:51:06Z",
  "message": "could not select service from the registry"
}

(presumably)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants