Another fix for converting custom ocs permissions to roles #4343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhafer
force-pushed
the
enterprise/6209
branch
from
0d5639d
to
0ed0cec
Compare
micbar
reviewed
Nov 15, 2023
| @@ -4,4 +4,5 @@ When creating shares with just `view` permission we wrongly converted that | |||
| into the `SpacerViewer` sharing role. The correct role for that would be `legacy`. | |||
|
|
|||
| https://github.com/cs3org/reva/pull/4342 | |||
| https://github.com/cs3org/reva/pull/4343 | |||
There was a problem hiding this comment.
Changelog check fails because 4343 needs to be on top of the list.
rhafer
force-pushed
the
enterprise/6209
branch
from
0ed0cec
to
73818e2
Compare
micbar
approved these changes
Nov 15, 2023
When creating (public) shares with the permissions read,update,create,delete we wrongly converted that into the `SpacerEditor` sharing role. The correct role for that would be `legacy`. Fixes: owncloud/enterprise#6209
rhafer
force-pushed
the
enterprise/6209
branch
from
73818e2
to
aaa7a2f
Compare
kobergj
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating (public) shares with the permissions read,update,create,delete we wrongly converted that into the
SpacerEditorsharing role. The correct role for that would belegacy.Fixes: https://github.com/owncloud/enterprise/issues/6209