Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Role "file-editor" does not have resharing permissions #4336

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

rhafer
Copy link
Contributor

@rhafer rhafer commented Nov 14, 2023

Similar to the generich "editor" role the "file-editor" should have resharing permissions.

When creating an "editor" file share using ocs. ocs already adds the AddGrant permission. This commit just about fixing the mapping of resource permission back to the corresponding role.

The idea is to move them to the graph service to get them closer to
where they're actually used.
@rhafer rhafer self-assigned this Nov 14, 2023
@rhafer rhafer requested review from labkode, glpatcern and a team as code owners November 14, 2023 13:31
Similar to the generich "editor" role the "file-editor" should have resharing
permissions.

When creating an "editor" file share using `ocs`. `ocs` already adds the `AddGrant`
permission. This commit just about fixing the mapping of resource permission back to
the corresponding role.
@micbar
Copy link
Member

micbar commented Nov 14, 2023

The bugfix is clear. Why do you remove the unified roles?

@rhafer
Copy link
Contributor Author

rhafer commented Nov 14, 2023

Why do you remove the unified roles?

@micbar As mentioned in the commit message on the first commit, I think libregraph specific stuff should not be part of reva so they'd better live with the graph service. See owncloud/ocis@9e50c42 . I am fine revisiting that if people disagree.

@micbar micbar merged commit f25c231 into cs3org:edge Nov 14, 2023
9 checks passed
rhafer added a commit to rhafer/ocis that referenced this pull request Nov 15, 2023
rhafer added a commit to rhafer/ocis that referenced this pull request Nov 15, 2023
rhafer added a commit to rhafer/ocis that referenced this pull request Nov 15, 2023
rhafer added a commit to rhafer/ocis that referenced this pull request Nov 15, 2023
fschade pushed a commit to rhafer/ocis that referenced this pull request Nov 16, 2023
fschade pushed a commit to rhafer/ocis that referenced this pull request Nov 16, 2023
fschade added a commit to owncloud/ocis that referenced this pull request Nov 17, 2023
* bump reva to latest edge

To get cs3org/reva#4336

* graph: Import unified role related code from reva

The UnifiedRole related types are pretty specific to the graph service.
Maintaining them as part of reva makes things more complex that required.

* chore: add failing cases to the expected failures

---------

Co-authored-by: Florian Schade <f.schade@icloud.com>
ownclouders pushed a commit to owncloud/ocis that referenced this pull request Nov 17, 2023
* bump reva to latest edge

To get cs3org/reva#4336

* graph: Import unified role related code from reva

The UnifiedRole related types are pretty specific to the graph service.
Maintaining them as part of reva makes things more complex that required.

* chore: add failing cases to the expected failures

---------

Co-authored-by: Florian Schade <f.schade@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants