Add missing expiry in shares #3895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragonchaser
requested review from
a team,
labkode,
ishank011 and
glpatcern
as code owners
Signed-off-by: Christian Richter <crichter@owncloud.com>
dragonchaser
force-pushed
the
issue-5442-missing-expiry-in-shares
branch
from
f38cc8e
to
6dbcdcc
Compare
kobergj
approved these changes
May 17, 2023
Comment on lines
1424
to
1427
| req.Grant.Expiration = &types.Timestamp{ | ||
| Seconds: uint64(ts.Unix()), | ||
| Nanos: 0, | ||
| } |
There was a problem hiding this comment.
There is utils.TimeToTS which could do this for you. But not critical.
There was a problem hiding this comment.
Thx, did not know that, incorporated it.
Signed-off-by: Christian Richter <crichter@owncloud.com>
This was referenced May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have added expiry dates to the shares
refs owncloud/ocis#5442