Fix unshare for EOS storage driver #3794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmgigi96
force-pushed
the
fix_unshare_eos
branch
from
ae84116
to
ef9fbce
Compare
gmgigi96
changed the title
glpatcern
approved these changes
Apr 15, 2023
Daniel-WWU-IT
pushed a commit
to Daniel-WWU-IT/reva
that referenced
this pull request
Apr 24, 2023
javfg
pushed a commit
to javfg/reva
that referenced
this pull request
Apr 26, 2023
javfg
pushed a commit
to javfg/reva
that referenced
this pull request
Apr 27, 2023
javfg
pushed a commit
to javfg/reva
that referenced
this pull request
Apr 27, 2023
gmgigi96
added a commit
to gmgigi96/reva
that referenced
this pull request
Jun 5, 2023
gmgigi96
added a commit
to gmgigi96/reva
that referenced
this pull request
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the EOS storage driver, the remove acl operation was a no-op. The consequence of this was that after removing a share, the recipient of the share was still able to operate on the shared resource.
Now this has been fixed in this PR.