Set correct share type when listing shares #3759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Excds
requested review from
a team,
labkode,
ishank011 and
glpatcern
as code owners
Excds
force-pushed
the
set_correct_share_type_when_listing_and_adding_sharees
branch
from
e72c96d
to
b6d5f05
Compare
micbar
approved these changes
Mar 31, 2023
micbar
force-pushed
the
set_correct_share_type_when_listing_and_adding_sharees
branch
from
a880af6
to
a9a93ef
Compare
internal/http/services/owncloud/ocs/handlers/apps/sharing/sharees/sharees.go
Outdated
Show resolved
Hide resolved
micbar
force-pushed
the
set_correct_share_type_when_listing_and_adding_sharees
branch
from
a9a93ef
to
45bcf92
Compare
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes so that we can differentiate between guest/member users for shares.
Description
List Shares
When listing shares on a file/folder with a GET on the following endpoint: /ocs/v1.php/apps/files_sharing/api/v1/shares the entities in the response have a shareType of 0 for all users, no matter if they are guests or not at the time of the request (already implemented like that). However, we need an additional attribute share_with_user_type for the shares where the user represented by the share_with* attributes is a guest (value 1) or not a guest (value 0) at the time of the request. The reason for this additional attribute instead of a shareType 0 vs 4 is that we don't want the need to migrate shares when a guest user becomes a non-guest or vice versa.
List sharees (share candidates)
when searching for potential sharees on a file/folder with a GET on the following endpoint:
/ocs/v2.php/apps/files_sharing/api/v1/sharees?search=ein the entities in the response have a shareType and a userType. shareType needs to be 0 and userType needs to be 1 for users that are guests at the time of the request. We pulled that out of demo.owncloud.com
@Excds @kobergj FYI