remove expired spaces grants on access #3655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C0rby
requested review from
a team,
labkode,
ishank011 and
glpatcern
as code owners
|
@micbar, can you tell me why the changelog step is failing? Do I need to change the order of the PR URLs or something else? |
I think the PR always needs to be in the first line of the list because it tries to match the id |
C0rby
force-pushed
the
space-member-expiration
branch
from
401c287
to
514f998
Compare
micbar
approved these changes
Feb 16, 2023
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I implement the spaces membership expiration I forgot to actually check the expiration and remove expired grants.
This adds these missing bits.
/cc @ScharfViktor when this was merged and reva was updated in oCIS then your tests should work.