FreeBSD xattr support #3650
Merged
FreeBSD xattr support #3650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a slight compatibilty issue due to FreeBSD disallowing usage of the `user.` prefix when it comes to xattr names. Just for FreeBSD this patch removes that `user.` prefix (leaving `ocis.`) which allows it to run on FreeBSD.
|
@joramkruijer Thanks for the PR! @butonic FYI |
butonic
approved these changes
Feb 13, 2023
|
@joramkruijer nice deep dive into the bowels, I guess! Could you add a changelog file in |
joramkruijer
requested review from
labkode,
ishank011 and
glpatcern
as code owners
|
@butonic Thanks, it sure was an interesting thing to solve! I've added the changelog entry you proposed, I think it covers the fix perfectly. |
butonic
approved these changes
Feb 14, 2023
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #3559, reva compiles perfectly fine on FreeBSD, but runs into problems with the
xattron FreeBSD:Failed to set all xattrs: xattr.Set user.ocis.blobsize: invalid argumentThis MR adds support for FreeBSD's xattr namespaces. On Linux, every namespace is accessible, but in FreeBSD (and in FreeBSD jails) this is not the case: the
userpart of the namespace is the only namespace writable, and is the implied namespace.Setting a namespace manually, i.e.
user.ociswill have the system refuse to use said namespace. Omitting theuser.part of the namespace on FreeBSD solves this bug. The complete namespace will still beuser.ocis, as FreeBSD prepends this part automatically.Many thanks to @BlackNovaTech for help with the debugging.