Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate ocisIntegrationTests and s3ngIntegrationTests to GitHub Actions #3640

Merged
merged 2 commits into from
Mar 7, 2023

Conversation

vascoguita
Copy link
Contributor

No description provided.

@phil-davis
Copy link
Contributor

https://github.com/cs3org/reva/actions/runs/4085928053/jobs/7044608957
"This step has been truncated due to its large size."

I guess that docker-compose is starting up the reva system-under-test and the test runner (behat...), but the system-under-test is spewing out large amounts of "log" output. Can that be cut down? Or the output redirected to /dev/null ? Or something.

Maybe then we will be able to see ocis/tests/acceptance/run.sh be executed, and behat start etc.

@vascoguita
Copy link
Contributor Author

https://github.com/cs3org/reva/actions/runs/4085928053/jobs/7044608957 "This step has been truncated due to its large size."

I guess that docker-compose is starting up the reva system-under-test and the test runner (behat...), but the system-under-test is spewing out large amounts of "log" output. Can that be cut down? Or the output redirected to /dev/null ? Or something.

Maybe then we will be able to see ocis/tests/acceptance/run.sh be executed, and behat start etc.

Sure, my latest commit should do it.

@vascoguita
Copy link
Contributor Author

https://github.com/cs3org/reva/actions/runs/4085928053/jobs/7044608957 "This step has been truncated due to its large size."

I guess that docker-compose is starting up the reva system-under-test and the test runner (behat...), but the system-under-test is spewing out large amounts of "log" output. Can that be cut down? Or the output redirected to /dev/null ? Or something.

Maybe then we will be able to see ocis/tests/acceptance/run.sh be executed, and behat start etc.

@phil-davis The output of the system-under-test has been suppressed and now we're able to see the output of ocis/tests/acceptance/run.sh: https://github.com/cs3org/reva/actions/runs/4125226916
Could you help us understand debug the tests please?

@phil-davis
Copy link
Contributor

Now it needs a rebase and resolve conflicts in .drone.env

The CI runs from last week do not have many unexpected failures. (from comment #3640 (comment) ) But somehow the rendering in the GitHub workflow output is very hard to read.

Do the rebase and I will look again.

Maybe I will need to get rid of the fancy colour output strings, which GitHub log output is not interpreting. That will make things easier to read.

@phil-davis
Copy link
Contributor

See #3672 - that works with the acceptance tests and the current drone scripts. The acceptance test output comes as plain text, without any escape sequence to select text colors etc.

If you rebase this PR, and set env variable PLAIN_OUTPUT in the workflows, then we should get a much cleaner output that we can read more easily and then look at why some tests are failing.

@vascoguita
Copy link
Contributor Author

See #3672 - that works with the acceptance tests and the current drone scripts. The acceptance test output comes as plain text, without any escape sequence to select text colors etc.

If you rebase this PR, and set env variable PLAIN_OUTPUT in the workflows, then we should get a much cleaner output that we can read more easily and then look at why some tests are failing.

Thanks Phil, PLAIN_OUTPUT is set now but errors on the run.sh script are causing the tests to fail. I see that you've fixed the variable assignments (owncloud/ocis#5624) and tried to bump ocis on reva (#3680 ) but it's failing Drone. I'll rebase and re-run GitHub Actions after it's fixed.

@vascoguita vascoguita linked an issue Feb 27, 2023 that may be closed by this pull request
@phil-davis
Copy link
Contributor

There is also #3679 waiting for approval and merge. After that is merged, I will stop changing test code! And we can concentrate on what failures remain.

@vascoguita
Copy link
Contributor Author

There is also #3679 waiting for approval and merge. After that is merged, I will stop changing test code! And we can concentrate on what failures remain.

Thanks @phil-davis , #3679 is now merged. Me and @labkode found that some tests were failing on Alma8 self-hosted runners so we upgraded the cluster used by my fork (only https://github.com/vascoguita/reva so far) to Alma9 but there are other tests failing.

@vascoguita vascoguita force-pushed the master branch 4 times, most recently from 2ab58a8 to 9168412 Compare March 7, 2023 14:55
@vascoguita vascoguita closed this Mar 7, 2023
@vascoguita vascoguita reopened this Mar 7, 2023
@vascoguita vascoguita force-pushed the master branch 2 times, most recently from 1a27b6a to a7fa855 Compare March 7, 2023 16:37
@vascoguita vascoguita marked this pull request as ready for review March 7, 2023 16:52
@vascoguita vascoguita merged commit 6bf090b into cs3org:master Mar 7, 2023
gmgigi96 pushed a commit to gmgigi96/reva that referenced this pull request Jun 28, 2023
…ns (cs3org#3640)

* Migrate ocisIntegrationTests and s3ngIntegrationTests to GitHub Actions

* Temporary fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants