Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expired authenticated public link error code #3528

Merged
merged 2 commits into from
Dec 8, 2022

Conversation

gmgigi96
Copy link
Member

@gmgigi96 gmgigi96 commented Dec 7, 2022

On an expired authenticated public link, the error returned from server was 401 unauthorized, behaving differently from a not-authenticated one, that returns 404 not found. This has been fixed in this PR, aligning the first case with the second.

@update-docs
Copy link

update-docs bot commented Dec 7, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@gmgigi96 gmgigi96 changed the title Fix expiration check on authenticated public links Fix expired authenticated public link error code Dec 7, 2022
@gmgigi96 gmgigi96 requested a review from a team as a code owner December 7, 2022 15:50
@gmgigi96 gmgigi96 force-pushed the expired_authenticated_publiclink branch from 21bd00d to e2ad6af Compare December 7, 2022 15:51
@labkode labkode merged commit dd3333f into cs3org:master Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants