[tests-only] Add vendor-php to .gitignore #3139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@glpatcern please review. |
glpatcern
previously approved these changes
Aug 10, 2022
phil-davis
changed the title
phil-davis
force-pushed
the
gitignore-vendor-php
branch
from
e80a782
to
1ae1799
Compare
|
@glpatcern I forgot to put "tests-only" - and CI stopped when it found that there was no changelog. I added [tests-only] to the PR title and force-pushed. IMO we do not need a changelog because this is only a development-tool-related change for developer convenience. After my force-push, GitHub has automatically dismissed your review - please review again, thanks. |
|
Yep, agreed, that's why I had approved even without the CI passing as this is totally neutral wrt code. |
glpatcern
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was done in the edge branch in PR #3106 commit 98e8bb6
Do it in master branch also.
The PHP test code dependencies were moved into
vendor-phpin master PR #2539 commit d09c6b9 about 6 months ago. We should have addedvendor-phpto.gitignoreback then.