Allow to run user_provider integration test with LDAP driver #2584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhafer
requested review from
labkode,
ishank011 and
glpatcern
as code owners
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
rhafer
force-pushed
the
ldap-integrationtest
branch
from
7274432
to
6f0f490
Compare
The test are skipped by default for now, as they require an LDAP Server
to be setup. To run you can e.g. use OpenLDAP in docker use e.g.:
```
docker run --name openldap \
--volume ./tests/integration/grpc/fixtures/ldap/:/container/service/slapd/assets/config/bootstrap/ldif/custom \
-e LDAP_DOMAIN="owncloud.com" \
-e LDAP_TLS_VERIFY_CLIENT=never \
-e LDAP_ORGANISATION=ownCloud \
-e LDAP_ADMIN_PASSWORD=admin \
-e LDAP_REMOVE_CONFIG_AFTER_SETUP=false \
osixia/openldap
```
run the test suite with:
```
cd tests/integration/
RUN_LDAP_TESTS=1 ~/go/bin/ginkgo [--focus "ldap"] ./...
```
If GetUser/GetGroup is called with the IDP attribute set to a non-empty string we only return results if the IDP setting configured for the user/groupprovider matches the IDP from the request. This aligns the LDAP providers' behaviour with what the demo and json providers implement.
CurrentGinkgoTestDescription() is deprecated in V2 and should be replaced with CurrentSpecReport().
rhafer
force-pushed
the
ldap-integrationtest
branch
from
6f0f490
to
169bcdb
Compare
26 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test are skipped by default for now, as they require an LDAP Server
to be setup. To run you can e.g. use OpenLDAP in docker use e.g.:
run the test suite with: