Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore handled errors when creating spaces #2439

Merged
merged 1 commit into from
Jan 13, 2022
Merged

ignore handled errors when creating spaces #2439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog/unreleased/ignore-known-erros.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Enhancement: ignore handled errors when creating spaces

The CreateStorageSpace no longer logs all error cases with error level logging

https://github.com/cs3org/reva/pull/2439
12 changes: 6 additions & 6 deletions internal/grpc/services/storageprovider/storageprovider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,13 +507,13 @@ func (s *service) CreateStorageSpace(ctx context.Context, req *provider.CreateSt
st = status.NewAlreadyExists(ctx, err, "already exists")
default:
st = status.NewInternal(ctx, "error listing spaces")
appctx.GetLogger(ctx).
Error().
Err(err).
Interface("status", st).
Interface("request", req).
Msg("failed to create storage space")
}
appctx.GetLogger(ctx).
Error().
Err(err).
Interface("status", st).
Interface("request", req).
Msg("failed to create storage space")
return &provider.CreateStorageSpaceResponse{
Status: st,
}, nil
Expand Down