cleanup toml config, add ocmd, drop gen subcommand #2239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
ishank011
reviewed
Nov 5, 2021
| @@ -87,8 +87,6 @@ driver = "json" | |||
| users = "users.demo.json" | |||
|
|
|||
| [http] | |||
| enabled_services = ["ocmd"] | |||
There was a problem hiding this comment.
@butonic can you add these back in ocmd-server-[1, 2]?
ishank011
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We updated the local and drone configurations, cleanad up the example configs and removed the reva gen subcommand which was generating outdated config.
This is in preparation for OCM tests. They are not included yet, but I want to see if starting ocmd breaks anything in the existing testsuite. Please merge as soon as CI passes.