add unit tests coverage #1983
add unit tests coverage #1983
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
@labkode this needs a |
|
@wkloucek I added the token and it seems to work now, but should we restrict sending the report only on merges? |
should also be on master, will have a look tomorrow |
| }, | ||
| "trigger":{ | ||
| "branch":[ | ||
| "master" |
There was a problem hiding this comment.
@ishank011 master should now also run the coverage report
There was a problem hiding this comment.
Should we change event to push?
There was a problem hiding this comment.
If you want you also can edit it directly. I must confess that I am not really familiar with the include / exclude logic of Drone since we are using the reference format for achieving the same "trigger": { "ref": [ "refs/heads/master", "refs/pull/**", ], },
There was a problem hiding this comment.
I'm not sure why we need push because PR and master should be the only cases!?
There was a problem hiding this comment.
"trigger": { "ref": [ "refs/heads/master", "refs/pull/**", ], }, is working fine in all owncloud repos
|
@labkode I'm not sure this is ready. @wkloucek @ishank011 and @micbar are on vacation for 2 weeks at least. Would be a shame to let this bitrot. |
|
Superseded by #2004 |
Adds coverage on unit tests to Codacy. Equals the setup at oCIS, where you can see the coverage on the dashboard. But I don't know why you cant see it at the files level though...
Manual check:
make testgo tool cover -func coverage.outtotal: (statements) 37.8%