Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added methods to get and put data into context #1938

Merged
merged 5 commits into from
Aug 3, 2021
Merged

Added methods to get and put data into context #1938

merged 5 commits into from
Aug 3, 2021

Conversation

jimil749
Copy link
Contributor

Signed-off-by: Jimil Desai jimildesai42@gmail.com

@jimil749
feat: added methods to get and put data into context
75e578a 
Signed-off-by: Jimil Desai <jimildesai42@gmail.com>
@jimil749 jimil749 requested a review from labkode as a code owner July 30, 2021 08:48
@update-docs
Copy link

update-docs bot commented Jul 30, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@jimil749
add changelog
5ca037a 
Signed-off-by: Jimil Desai <jimildesai42@gmail.com>
@jimil749 jimil749 requested a review from ishank011 July 30, 2021 08:52
ishank011
ishank011 reviewed Jul 30, 2021
View reviewed changes
Copy link
Contributor

@ishank011 ishank011 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put this code in a separate file in the same package. Maybe ctxmap.go. And can you also add some unit tests?

@jimil749
code refractor and unit test
eaa3683 
Signed-off-by: Jimil Desai <jimildesai42@gmail.com>
@jimil749
Copy link
Contributor Author

@ishank011 I tried to add the unit tests but it fails when I run with go test -race (Seems to work fine when run it without the race flag). Not totally sure why.
It fails with the following error:

fatal error: checkptr: pointer arithmetic result points to invalid allocation

jimil749
jimil749 commented Jul 30, 2021
View reviewed changes
pkg/appctx/ctxmap.go Outdated Show resolved Hide resolved
ishank011 and others added 2 commits July 30, 2021 16:34
@ishank011
Use reflection to manipulate valueCtx objects
05c6f4d
@jimil749
fix: update changelog
5c38707 
Signed-off-by: Jimil Desai <jimildesai42@gmail.com>
@labkode labkode merged commit afe617a into cs3org:master Aug 3, 2021
@jimil749 jimil749 deleted the context-methods branch August 3, 2021 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishank011 ishank011 ishank011 left review comments

@labkode labkode labkode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jimil749 @labkode @ishank011