Fix public file shares #1666
Merged
Fix public file shares #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 27, 2021 13:49
To be able to create the `downloadURL` in the propfind response we need to access the link share. Before this change only the root collection was able to access the link share
When doing a stat request in the public storage we need to differentiate between folder and file shares. If we want to stat a file in folder shares we need to concatenate the originalPath and the relative path because the originalPath is only the path to the share root. That means only up to the shared folder and the relative path contains the file path from the share root. The originalPath in file share is already pointing to the shared file so we don't need to append the relative path there.
ishank011
approved these changes
Apr 30, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed stat requests and propfind responses for publicly shared files.
downloadURLin the propfind response we need to access the link share. Before this change only the root collection was able to access the link shareThe originalPath in file share is already pointing to the shared file so
we don't need to append the relative path there.