Makefile: added make command to run litmus-tests

[jimil749]

Fixes #1106

This PR adds an extra make command to run litmus tests via make.

• make litmus-test executes the tests.

Signed-off-by: Jimil Desai jimildesai42@gmail.com

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[ishank011]

Hi @jimil749! Thanks for opening the PR. Good work! Just a few comments:

• Please add the build rule as a dependency for this one, as we assume that the revad binary is already present.
• The revad daemons should be killed after the tests are run. We can use pkill or any other graceful method to shut those down.
• Please add a changelog for the PR to the unreleased directory. You can refer the other files for the format.

[jimil749]

@ishank011 I've updated accordingly!

[ishank011]

Hi @jimil749 thanks for the change. I forgot to add one thing, sorry about that!

We now expose two WebDAV endpoints, one which assumes the namespace to be that of the logged-in user (remote.php/webdav), and another that has access to other users' as well projects' spaces (remote.php/dav/files/{UID}). Can you add separate commands for the two? We have that in the CI.

reva/.drone.star

Lines 452 to 460 in 3b7e1f0

	"name": "litmus-owncloud-new-webdav",
	"image": "registry.cern.ch/docker.io/owncloud/litmus:latest",
	"environment": {
	# UUID is einstein user, see https://github.com/owncloud/ocis-accounts/blob/8de0530f31ed5ffb0bbb7f7f3471f87f429cb2ea/pkg/service/v0/service.go#L45
	"LITMUS_URL": "http://revad-services:20080/remote.php/dav/files/4c510ada-c86b-4815-8820-42cdf82c3d51",
	"LITMUS_USERNAME": "einstein",
	"LITMUS_PASSWORD": "relativity",
	"TESTS": "basic http copymove props",
	}

Also, we should add the TEST env variable to specify which tests to run, as not all functionalities are currently implemented.

[jimil749]

Sure, will do!

[jimil749]

@ishank011, we want a separate make command for both the WebDAV endpoints, right? Maybe litmus-test-old and litmus-test-new, I am not sure about the naming here.

[ishank011]

Yep, I think those should be good.

[jimil749]

@ishank011 I have updated as requested. Though, I am not sure why the tests are failing. 😅

[ishank011]

Can you rebase? We updated the commit from the owncloud repo used to run the integration tests, so now it should pass.

[ishank011]

LGTM. Nice work!