Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the .git dir back into the revad image #1413

Merged
merged 1 commit into from
Jan 19, 2021
Merged

Add the .git dir back into the revad image #1413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
.github
.git
changelog
docs
examples
Expand Down
4 changes: 4 additions & 0 deletions changelog/unreleased/fix-version-string.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Bugfix: re-include the '.git' dir in the Docker images to pass the version tag
and git SHA to the release tool.

https://github.com/cs3org/reva/pull/1413
2 changes: 1 addition & 1 deletion cmd/revad/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ func main() {
func handleVersionFlag() {
if *versionFlag {
fmt.Fprintf(os.Stderr, "%s\n", getVersionString())
os.Exit(1)
os.Exit(0)
}
}

Expand Down