return the users username instead of the uuid in share responses #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs
previously approved these changes
Dec 9, 2020
There was a problem hiding this comment.
👍 my only concern is that UserServiceUserIDResolver returns a (string, error) tuple. I see how this is useful for consensus and have a resp.User.Username everywhere instead of a UUID I find that a more generic / higher-level API would fit better for a larger project. The conversions package by definition is convoluted.
C0rby
force-pushed
the
change/ocs-share-api-userid
branch
3 times, most recently
from
b5098b8
to
fcb36cc
Compare
|
This PR doesn't seem to trigger drone builds anymore... |
|
PR #1364 also has no drone. Maybe also ask in chat somewhere? |
|
So I ran the two of the failed pipelines locally using |
C0rby
force-pushed
the
change/ocs-share-api-userid
branch
from
fcb36cc
to
a712017
Compare
C0rby
force-pushed
the
change/ocs-share-api-userid
branch
from
a712017
to
1af72bb
Compare
|
Closing because of PR against the unsafe branch #1370 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while ago we decided to use the users uuid only internally and to only display or return the users username. The ocs share api did still return the uuid.
Closes owncloud/ocis#990