Resolve a WOPI bridge appProviderURL #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
glpatcern
force-pushed
the
app-wopibridge
branch
4 times, most recently
from
7eb0fad
to
af822c8
Compare
glpatcern
changed the title
glpatcern
commented
Oct 12, 2020
|
|
||
| // In case of applications served by the WOPI bridge, resolve the URL and go to the app | ||
| // Note that URL matching is performed via string matching, not via IP resolution: may need to fix this |
There was a problem hiding this comment.
This is ready for review, and I explicitly bring the attention to this note ;-) Feedback welcome.
glpatcern
force-pushed
the
app-wopibridge
branch
from
af822c8
to
4fcbfbd
Compare
ishank011
reviewed
Oct 16, 2020
There was a problem hiding this comment.
Hi @glpatcern, apologies for the delay in the review. Just a minor nit, rest looks good.
glpatcern
force-pushed
the
app-wopibridge
branch
from
531c835
to
a6d426e
Compare
glpatcern
force-pushed
the
app-wopibridge
branch
from
a6d426e
to
1b9847d
Compare
labkode
approved these changes
Oct 19, 2020
ishank011
approved these changes
Oct 21, 2020
glpatcern
added a commit
to glpatcern/reva
that referenced
this pull request
Oct 28, 2020
glpatcern
added a commit
to glpatcern/reva
that referenced
this pull request
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minor addition to simplify user interaction: if the
AppProviderUrlis to be served by the WOPI bridge, resolve it byGETting it and returning the redirected URL as the realAppProviderUrlvalue.