Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] enable group shares #1220

Closed
wants to merge 1 commit into from
Closed

[WIP] enable group shares #1220

wants to merge 1 commit into from

Conversation

butonic
Copy link
Contributor

@butonic butonic commented Oct 2, 2020 •
edited
Loading

We are tentatively allowing group shares. Currently, the shareWith is used as is and persisted in the storage as is ...

  • the name of a group might change, then the share will break
  • reva currently has neither an API to look up a group id nor a group display name
  • other than the above ... I could share with the users group and access a folder :-)

tested on top of #1219 and #1213 but can be merged standalone

@butonic butonic requested a review from labkode as a code owner October 2, 2020 20:39
@update-docs
Copy link

update-docs bot commented Oct 2, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@butonic
enable group shares
a777d82 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@ishank011 ishank011 closed this May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkode labkode Awaiting requested review from labkode labkode is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@butonic @ishank011