Do not send body on failed range request (#1884)

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
cs3org · Jul 13, 2021 · 0e9bd80 · 0e9bd80
1 parent f8b91e1
commit 0e9bd80
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/changelog/unreleased/no-body-on-failed-range.md b/changelog/unreleased/no-body-on-failed-range.md
@@ -0,0 +1,5 @@
+Bugfix: Do not send body on failed range request
+
+Instead of send the error in the body of a 416 response we log it. This prevents the go reverse proxy from choking on it and turning it into a 502 Bad Gateway response.
+
+https://github.com/cs3org/reva/pull/1884
diff --git a/pkg/rhttp/datatx/utils/download/download.go b/pkg/rhttp/datatx/utils/download/download.go
@@ -68,8 +68,9 @@ func GetOrHeadFile(w http.ResponseWriter, r *http.Request, fs storage.FS) {
 			if err == ErrNoOverlap {
 				w.Header().Set("Content-Range", fmt.Sprintf("bytes */%d", md.Size))
 			}
+			sublog.Error().Err(err).Interface("md", md).Interface("ranges", ranges).Msg("range request not satisfiable")
 			w.WriteHeader(http.StatusRequestedRangeNotSatisfiable)
-			fmt.Fprintln(w, err)
+
 			return
 		}
 		if SumRangesSize(ranges) > int64(md.Size) {