Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reference to GetQuota rpc #147

Merged
merged 1 commit into from
Oct 6, 2021
Merged

Add reference to GetQuota rpc #147

merged 1 commit into from
Oct 6, 2021

Conversation

micbar
Copy link
Member

@micbar micbar commented Sep 23, 2021

Description

  • To query also the quota of a storage space, we need an optional parameter in the GetQuota rpc

@micbar micbar changed the title Add space id to GetQuota service Add space id to GetQuota rpc Sep 24, 2021
@butonic
Copy link
Contributor

butonic commented Oct 4, 2021

@micbar can you rebase?

micbar
micbar commented Oct 4, 2021
View reviewed changes
Copy link
Member Author

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// The reference to which the action should be performed.
cs3.storage.provider.v1beta1.Reference ref

Use a reference to pass on to the storage provider

@micbar
Copy link
Member Author

micbar commented Oct 4, 2021

rebased and using the reference now.

@micbar micbar changed the title Add space id to GetQuota rpc Add reference to GetQuota rpc Oct 6, 2021
@ishank011 ishank011 merged commit 656f69e into cs3org:main Oct 6, 2021
@micbar micbar mentioned this pull request Oct 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refs refs refs approved these changes

@ishank011 ishank011 ishank011 approved these changes

@labkode labkode Awaiting requested review from labkode labkode is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@micbar @butonic @refs @ishank011