Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rpc): wrong block number in debug trace related api (backport: #1591) #213

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Mar 7, 2023

for more info

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

mmsqe and others added 2 commits March 7, 2023 09:12
* fix wrong block number in debug_traceTransaction

* add change doc

* update nix

* update nix

Co-authored-by: Freddy Caceres <facs95@gmail.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #213 (872fb68) into release/v0.20.x-cronos (95ec96b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@                   Coverage Diff                   @@
##           release/v0.20.x-cronos     #213   +/-   ##
=======================================================
  Coverage                   57.27%   57.27%           
=======================================================
  Files                         108      108           
  Lines                       10104    10104           
=======================================================
  Hits                         5787     5787           
  Misses                       4071     4071           
  Partials                      246      246           
Impacted Files Coverage Δ
x/evm/keeper/grpc_query.go 87.58% <100.00%> (ø)

@yihuang yihuang merged commit 837d0b0 into crypto-org-chain:release/v0.20.x-cronos Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants