Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: don't support debug query result (backport: #328) #342

Merged

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Feb 14, 2022

Solution:

  • update cosmos-sdk dependency, the feature is backported to cosmos-sdk 0.44.x

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@yihuang yihuang requested a review from a team as a code owner February 14, 2022 14:44
@yihuang yihuang requested review from devashishdxt and adu-crypto and removed request for a team February 14, 2022 14:44
@yihuang yihuang marked this pull request as draft February 14, 2022 14:45
go.mod Outdated Show resolved Hide resolved
@yihuang yihuang marked this pull request as ready for review February 15, 2022 02:18
@thomas-nguy
Copy link
Collaborator

why is this PR pointed to release/v0.6.x?

@yihuang yihuang changed the title Problem: don't support debug query result Problem: don't support debug query result (backport: #328) Feb 16, 2022
@yihuang
Copy link
Collaborator Author

yihuang commented Feb 16, 2022

why is this PR pointed to release/v0.6.x?

it's a backport, the feature is backported to cosmos-sdk 0.44.x, for easier debugging.

@@ -4,7 +4,7 @@ go 1.17

require (
github.com/armon/go-metrics v0.3.9
github.com/cosmos/cosmos-sdk v0.44.3
github.com/cosmos/cosmos-sdk v0.44.6
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

@yihuang yihuang Feb 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solution:
- update cosmos-sdk dependency

changelog
Copy link
Collaborator

@thomas-nguy thomas-nguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine after a quick check of the changelog of cosmos sdk

Just to confirm, events are not store in consensus hash right?
cosmos/cosmos-sdk#10631

@yihuang
Copy link
Collaborator Author

yihuang commented Feb 16, 2022

Just to confirm, events are not store in consensus hash right? cosmos/cosmos-sdk#10631

I think it is stored in consensus hash, so it looks like breaking, maybe better to cherry-pick to a custom fork then.

@yihuang yihuang marked this pull request as draft February 16, 2022 03:10
@tomtau
Copy link
Contributor

tomtau commented Feb 16, 2022

I think events used to be in the consensus in TM 0.33 or something like that, but it was later removed (it's up to ABCI apps to do it themselves now)

@yihuang yihuang marked this pull request as ready for review February 16, 2022 03:57
@yihuang
Copy link
Collaborator Author

yihuang commented Feb 16, 2022

I think events used to be in the consensus in TM 0.33 or something like that, but it was later removed (it's up to ABCI apps to do it themselves now)

that's great, @mofhusseini has run a node with this version, haven't seen app hash mismatch issue yet.

@tomtau
Copy link
Contributor

tomtau commented Feb 16, 2022

Just for reference: events were perhaps hashed into block headers pre-0.33, not hashed in 0.33, but considered to be hashed again for 0.34, but it was decided not to hash them: tendermint/tendermint#5134 (comment) :D
I believe it's still the case and even 0.35 remains like this, but I didn't follow the development in detail -- @JayT106 can double-check it.

@JayT106
Copy link
Collaborator

JayT106 commented Feb 16, 2022

@tomtau is correct, the current block header doesn't have the event hash in v0.34 and later release.

Only LastResultsHash has been stored in the header to represent the hash of the transactions' results

@yihuang yihuang merged commit 16dab5d into crypto-org-chain:release/v0.6.x Feb 17, 2022
@yihuang yihuang deleted the debug-query-result-0.6.x branch February 17, 2022 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants