Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent code formatting througout project #351

Closed
1 task done
brylie opened this issue Jun 2, 2021 · 0 comments · Fixed by #352
Closed
1 task done

Inconsistent code formatting througout project #351

brylie opened this issue Jun 2, 2021 · 0 comments · Fixed by #352
Assignees
@brylie
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work

Comments

@brylie
Copy link
Contributor

brylie commented Jun 2, 2021

Description

There are many inconsistencies in the code formatting throughout the project.

Reproduction

  1. clone the code
  2. run npx prettier --check "**/*.js"

Expectation

We should adhere to Prettier guidelines, since the Prettier package is listed as a dev dependency:

chooser/package.json

Line 59 in 99d4ccc

"prettier": "^1.19.1",

Many code editors can automatically format code on save. However, fixing the formatting issues during the course of development can create a bit of noise in pull requests. Let's fix project code formatting with a single sweep.

Resolution

  • I would be interested in resolving this bug.
@brylie brylie added 🟧 priority: high Stalls work on the project or its dependents 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Jun 2, 2021
@brylie brylie mentioned this issue Jun 2, 2021
Merged
7 tasks
@brylie brylie self-assigned this Jun 3, 2021
@dijitali dijitali mentioned this issue Apr 5, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brylie brylie

Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Format all code using Prettier and eslint creativecommons/chooser
1 participant
@brylie