Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming panorama folder in CS2 pak01_dir.vpk freezes the app #136

Open
szmarczak opened this issue Apr 27, 2024 · 3 comments
Open

Renaming panorama folder in CS2 pak01_dir.vpk freezes the app #136

szmarczak opened this issue Apr 27, 2024 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@szmarczak
Copy link

Describe the Bug

obraz

To Reproduce

As in the title.

Operating System

Windows 11, VPKEdit v4.2.0

@szmarczak szmarczak added the bug Something isn't working label Apr 27, 2024
@craftablescience craftablescience modified the milestones: 4.2, 4.3 Apr 27, 2024
@craftablescience
Copy link
Owner

To the best of my knowledge it actually does work, it just takes a very long time to complete the operation. So I suggest two things for myself to implement:

  • Add an indeterminate progress bar to the application when renaming directories, so it doesn't appear to freeze
  • Change the internal data structure used to hold pack files in memory so renaming directories is quicker

The last one will be a larger refactor, but the first one is easy to do and will be tracked by this issue.

@craftablescience craftablescience modified the milestones: 4.3, 4.X, 4.2 Apr 27, 2024
@craftablescience craftablescience modified the milestones: 4.2, 4.3 May 27, 2024
@craftablescience
Copy link
Owner

Due to some stupid technical nonsense I'm going to have to push this back and only do the second item in that list, which is what the correct fix for the issue is anyways

@craftablescience
Copy link
Owner

To the best of my knowledge it actually does work, it just takes a very long time to complete the operation. So I suggest two things for myself to implement:

  • Add an indeterminate progress bar to the application when renaming directories, so it doesn't appear to freeze
  • Change the internal data structure used to hold pack files in memory so renaming directories is quicker

The last one will be a larger refactor, but the first one is easy to do and will be tracked by this issue.

Done both of these things, but I still need to hook up the fast rename path to the GUI, which is proving a bit more difficult than I thought it would be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants