Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support evcxr kernel in jupyter notebook #59

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Conversation

wangjiawen2013
Copy link
Contributor

Display the plot in jupyter notebook thanks to the evcxr kernel.

@wangjiawen2013
Copy link
Contributor Author

wangjiawen2013 commented Aug 19, 2024

@cpmech
Hi,
I have pulled the request, but it seems that something happened when uploading the code, you can see the details here (https://github.com/cpmech/plotpy/actions/runs/10430518815/job/28926195783?pr=59):

[2024-08-19T04:55:34.790Z] ['info'] Processing /home/runner/work/plotpy/plotpy/lcov.info...
[2024-08-19T04:55:34.797Z] ['info'] Detected GitHub Actions as the CI provider.
[2024-08-19T04:55:34.978Z] ['info'] Pinging Codecov: https://codecov.io/upload/v4?package=github-action-3.1.6-uploader-0.8.0&token=*******&branch=main&build=10430518815&build_url=https%3A%2F%2Fgithub.com%2Fcpmech%2Fplotpy%2Factions%2Fruns%2F10430518815%2Fjob%2F[28](https://github.com/cpmech/plotpy/actions/runs/10430518815/job/28918820183?pr=59#step:7:29)926195783&commit=25e6adc92cf709de4e428188239784c5903806ca&job=Test+%26+Coverage&pr=59&service=github-actions&slug=cpmech%2Fplotpy&name=&tag=&flags=&parent=
[2024-08-19T04:55:35.316Z] ['error'] There was an error running the uploader: Error uploading to https://codecov.io: Error: There was an error fetching the storage URL during POST: 4[29](https://github.com/cpmech/plotpy/actions/runs/10430518815/job/28918820183?pr=59#step:7:30) - {'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 469s.', code='throttled')}
Error: Codecov: Failed to properly upload: The process '/home/runner/work/_actions/codecov/codecov-action/v3/dist/codecov' failed with exit code 255

Here s a related issue (codecov/codecov-action#598), maybe some configurations should be made for this github repository (such as CODECOV_VERSION or secret token). Could you check that and merge the request ?

@cpmech
Copy link
Owner

cpmech commented Aug 19, 2024

Hi, thank you for the PR!

It seems that codecov is not working at the moment. I'm trying since this morning but still it won't work.

I'll wait a little longer and will keep trying.

Meanwhile, could you please rename the function show to show_in_evcxr

@wangjiawen2013
Copy link
Contributor Author

Renamed.

src/plot.rs Outdated Show resolved Hide resolved
@cpmech cpmech merged commit 4198a64 into cpmech:main Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants