Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gofmt #26

Closed
wants to merge 1 commit into from
Closed

gofmt #26

wants to merge 1 commit into from

Conversation

whilei
Copy link

@whilei whilei commented Jun 16, 2018

Just ran

gofmt -w .

on the project root. That's all.

https://blog.golang.org/go-fmt-your-code

I made this PR with a project going on over at https://github.com/rotblauer/gofmt-att, and it's definitely a work in progress. So if I got something wrong, or this is annoying at all, please file an issue over there and we'll sort it out.

@whilei
all: gofmt
8da57cf 
Run standard gofmt command on project root.

- go version go1.10.3 darwin/amd64

Signed-off-by: ia <isaac.ardis@gmail.com>
@cosmos72
Copy link
Owner

It's better to leave the code as it is now.
Let me explain the reasons:
Almost all the changes in this PR are for auto-generated files, and the changes would be lost the next time such files are recreated.
Also, after applying this PR, comparing recreated files (before committing them) to their previous version would become very difficult because of the different formatting.

@cosmos72 cosmos72 closed this Jun 16, 2018
@whilei
Copy link
Author

whilei commented Jun 17, 2018

@cosmos72 Copy that. Sorry, I'm trying to avoid pointing this thing at the auto-generated files. Do you use a certain pattern for naming auto-generated files? _template?... I noticed there were a lot of those. Just trying to get patterns for the blacklist.

@cosmos72
Copy link
Owner

cosmos72 commented Jun 17, 2018 •
edited
Loading

The most general pattern I can give you for generated source files in gomacro is:
They have a comment near the beginning
// DO NOT EDIT! this file was generated automatically [...]

@whilei whilei mentioned this pull request Jun 18, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whilei @cosmos72