New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-export all crates that have types present in our public API #697

Closed

plafer opened this issue May 31, 2023 · 0 comments · Fixed by #975

Assignees

Labels

Milestone

Contributor

plafer commented May 31, 2023

For example, our public API requires ibc_proto::google::protobuf::Any. We should thus re-export ibc_proto in our lib.rs.

This will have many benefits:

When users upgrade their ibc-rs dependency (not through cargo update), it will just work, as opposed to showing a bunch of errors which effectively mean "upgrade ibc-proto as well".
It will make the ClientState derive macro (implemented in Static ClientState API #683) slightly cleaner (i.e. users will be allowed to rename their ibc_proto without breaking the macro).

The text was updated successfully, but these errors were encountered:

plafer added the O: usability label

Farhad-Shabani mentioned this issue

feat: restructure ibc crate #975

Merged

7 tasks

Farhad-Shabani closed this as completed in #975

Farhad-Shabani added this to the v0.48.0 milestone

Farhad-Shabani self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment