Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that round-tripped data is equal in tests #497

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Check that round-tripped data is equal in tests #497

merged 1 commit into from
Mar 6, 2023

Conversation

kevinji
Copy link
Contributor

@kevinji kevinji commented Mar 4, 2023

Closes: #XXX

Description

This re-adds a check that was previously commented out.


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@codecov
Copy link

codecov bot commented Mar 4, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (127f129) 71.52% compared to head (da09d69) 71.52%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #497   +/-   ##
=======================================
  Coverage   71.52%   71.52%           
=======================================
  Files         125      125           
  Lines       15890    15893    +3     
=======================================
+ Hits        11365    11368    +3     
  Misses       4525     4525           
Impacted Files Coverage Δ
crates/ibc/src/test.rs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@plafer plafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@plafer plafer merged commit 298c39e into cosmos:main Mar 6, 2023
@kevinji kevinji deleted the check-serde-eq branch March 6, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants