Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'static requirement on Module #490

Closed
Tracked by #431
plafer opened this issue Mar 1, 2023 · 2 comments · Fixed by #499
Closed
Tracked by #431

Remove 'static requirement on Module #490

plafer opened this issue Mar 1, 2023 · 2 comments · Fixed by #499
Assignees
@plafer
Milestone
v0.32.0

Comments

@plafer
Copy link
Contributor

plafer commented Mar 1, 2023

Implicitly through AsAnyMut
@plafer plafer self-assigned this Mar 1, 2023
@plafer plafer mentioned this issue Mar 2, 2023
Closed
7 tasks
@romac
Copy link
Member

romac commented Mar 3, 2023

Can you expand a bit on why this is needed?

@plafer
Copy link
Contributor Author

plafer commented Mar 3, 2023

It was requested by Namada (see their Context object they want to implement Module for). And I find this to be a good change in general as it gives more flexibility to implementors, without many drawbacks (if any?) for us.

@Farhad-Shabani Farhad-Shabani mentioned this issue Mar 4, 2023
Merged
7 tasks
@plafer plafer mentioned this issue Mar 6, 2023
Merged
7 tasks
@Farhad-Shabani Farhad-Shabani added this to the v0.32.0 milestone Mar 6, 2023
@Farhad-Shabani Farhad-Shabani mentioned this issue Mar 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plafer plafer

Labels
None yet
Projects
ibc-rs
Status: ✅ Done
Milestone
v0.32.0
Development

Successfully merging a pull request may close this issue.

Allow for non-'static Module cosmos/ibc-rs
Allow for non-'static Module cosmos/ibc-rs
3 participants
@romac @plafer @Farhad-Shabani