Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the ibc-testkit work with no_std #329

Open
plafer opened this issue Jan 6, 2023 · 2 comments
Open

Make the ibc-testkit work with no_std #329

plafer opened this issue Jan 6, 2023 · 2 comments
Labels
A: blocked Admin: blocked by another (internal/external) issue or PR A: good-first-issue Admin: good for newcomers A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews S: no-std Scope: support no_std envs

Comments

@plafer
Copy link
Contributor

plafer commented Jan 6, 2023 •
edited by Farhad-Shabani
Loading

Supersedes: #318
Blocked on: informalsystems/tendermint-rs#1258

We should have the ibc-testkit not require std since there's no fundamental reason why it should. This involves:

  1. Don't use Timestamp::now() which reads time from the OS; implement logic to advance time everytime a "mock now()" is called instead.
  2. Use the no_std version of tendermint-testgen when available
@plafer plafer mentioned this issue Jan 6, 2023
Merged
7 tasks
@plafer plafer added A: good-first-issue Admin: good for newcomers A: blocked Admin: blocked by another (internal/external) issue or PR S: no-std Scope: support no_std envs A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews labels Jan 6, 2023
@Farhad-Shabani Farhad-Shabani modified the milestones: Shepherd open source contributions from users, v0.28.0 Feb 3, 2023
@Farhad-Shabani
Copy link
Member

We have removed mocks-no-std, as of this PR: #825

@Farhad-Shabani Farhad-Shabani changed the title Remove mocks-no-std feature Make the mocks feature work with no_std Oct 18, 2023
@Farhad-Shabani
Copy link
Member

Though moved away from the old "mocks-no-std", the core issue still persists.

@Farhad-Shabani Farhad-Shabani mentioned this issue Oct 18, 2023
Merged
7 tasks
@Farhad-Shabani Farhad-Shabani changed the title Make the mocks feature work with no_std Make the ibc-testkit crate work with no_std Nov 27, 2023
@Farhad-Shabani Farhad-Shabani changed the title Make the ibc-testkit crate work with no_std Make the ibc-testkit work with no_std Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A: blocked Admin: blocked by another (internal/external) issue or PR A: good-first-issue Admin: good for newcomers A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews S: no-std Scope: support no_std envs
Projects
ibc-rs
Status: 📥 To Do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@plafer @Farhad-Shabani