Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Ics* names to something more descriptive #245

Closed
plafer opened this issue Nov 16, 2022 · 4 comments · Fixed by #247
Closed

Rename Ics* names to something more descriptive #245

plafer opened this issue Nov 16, 2022 · 4 comments · Fixed by #247
Assignees
@DaviRain-Su
Labels
O: new-feature Objective: aims to add new feature

Comments

@plafer
Copy link
Contributor

plafer commented Nov 16, 2022

We use this pattern a lot in the codebase, and I think we should move away from it. For example, Ics20Context could be renamed to TransferContext.
@plafer plafer added the O: new-feature Objective: aims to add new feature label Nov 16, 2022
@DaviRain-Su
Copy link
Contributor

This enhancement can be assigned to me

@plafer
Copy link
Contributor Author

plafer commented Nov 17, 2022

Thanks!

@DaviRain-Su
Copy link
Contributor

Ics26Context Rename to RoutingContext?

@plafer
Copy link
Contributor Author

plafer commented Nov 17, 2022

I would be more in favor of RouterContext, but we can discuss this further on the PR itself

@DaviRain-Su DaviRain-Su mentioned this issue Nov 18, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DaviRain-Su DaviRain-Su

Labels
O: new-feature Objective: aims to add new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename ics context octopus-network/ibc-rs
2 participants
@plafer @DaviRain-Su