Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timestamp comparison in client expiration logic #1239

Closed
rnbguy opened this issue May 24, 2024 · 0 comments · Fixed by #1287
Closed

timestamp comparison in client expiration logic #1239

rnbguy opened this issue May 24, 2024 · 0 comments · Fixed by #1287
Labels
A: bug Admin: something isn't working
Milestone

Comments

@rnbguy
Copy link
Collaborator

rnbguy commented May 24, 2024

The following inequality should be >=

if elapsed_since_latest_consensus_state > client_state.trusting_period {
return Ok(Status::Expired);

Considering the is_within_trust_period logic from tendermint-rs.

To summarize, tendermint-rs expires a header at trusted_header_time + trusting_period. However, in ibc-rs, a header is active till trusted_header_time + trusting_period.

@rnbguy rnbguy changed the title duration inequality in client expiration logic timestamp comparison in client expiration logic May 24, 2024
@rnbguy rnbguy added the A: bug Admin: something isn't working label Jun 27, 2024
@Farhad-Shabani Farhad-Shabani added this to the 0.54.0 milestone Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Admin: something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants