Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/staking/simulation/params.go: add unit tests #6693

Merged
merged 2 commits into from
Jul 12, 2020

Conversation

dauTT
Copy link
Contributor

@dauTT dauTT commented Jul 11, 2020

Description

closes a sub-task related to issue #5007


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Jul 11, 2020

Codecov Report

Merging #6693 into master will increase coverage by 3.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6693      +/-   ##
==========================================
+ Coverage   55.11%   58.23%   +3.11%     
==========================================
  Files         338      505     +167     
  Lines       19460    30714   +11254     
==========================================
+ Hits        10725    17885    +7160     
- Misses       7978    11507    +3529     
- Partials      757     1322     +565     

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez
Copy link
Contributor

alexanderbez commented Jul 12, 2020

How does this decrease coverage @marbar3778 @alessio?

@alexanderbez alexanderbez merged commit 2de851d into cosmos:master Jul 12, 2020
@dauTT dauTT deleted the staking-sim-test-param-5007 branch July 12, 2020 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants