Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch GetConfirmation()'s default to no #4575

Merged
merged 2 commits into from
Jun 18, 2019
Merged

switch GetConfirmation()'s default to no #4575

merged 2 commits into from
Jun 18, 2019

Commits on Jun 18, 2019

  1. switch GetConfirmation()'s default to no 

    GetConfirmation() returns true if and only if the user's
input is confirmative.

The function is used in places where fat-fingering may cause
financial loss, e.g. gaiacli tx send command. Thus it seems
wiser to provide a conservative default in order to protect
users from accidental mistyping.

Closes: #4564
    @alessio
    alessio committed Jun 18, 2019
    Configuration menu
    Copy the full SHA
    3ebd439 View commit details
    Browse the repository at this point in the history

  2. Fix test

    @alessio
    alessio committed Jun 18, 2019
    Configuration menu
    Copy the full SHA
    0d54cca View commit details
    Browse the repository at this point in the history