Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Failed Simulation Seeds #4140

Merged
merged 4 commits into from
Apr 22, 2019
Merged

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Apr 17, 2019

  • Fixes a hang where only one account is generated
  • Fixes the situation where a vesting account's end time and start time are the same

closes: #4139


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Apr 17, 2019

Codecov Report

Merging #4140 into develop will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop   #4140      +/-   ##
==========================================
+ Coverage    60.18%   60.2%   +0.02%     
==========================================
  Files          212     212              
  Lines        15157   15157              
==========================================
+ Hits          9122    9126       +4     
+ Misses        5411    5407       -4     
  Partials       624     624

@alexanderbez
Copy link
Contributor Author

alexanderbez commented Apr 17, 2019

I am stumped as to why test_sim_gaia_simulation_after_import consistently fails. It passes for me locally and passes for me on Zaki's megabox. I've noticed this on other PRs too; after eventually enough retries it passes. I don't think this is non-determinism, but something to do with the script or the OS.

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez alexanderbez merged commit df6f2d6 into develop Apr 22, 2019
@alexanderbez alexanderbez deleted the 4139-fix-failed-sim-faults branch April 22, 2019 14:58
@alexanderbez alexanderbez mentioned this pull request May 23, 2019
5 tasks
alexanderbez added a commit that referenced this pull request May 23, 2019
* Cherry Pick PR #4345: Upgrade ledger-cosmos-go

* Cherry Pick PR #4336: Fix AppendTags usage error

* Update modules

* Cherry Pick PR #4265: CacheKVStore keep sorted items

* Cherry Pick #4227: Adding support for Ledger Cosmos App v1.5

* Cherry Pick #4395: Improve sig verification error message

* Cherry Pick PR #4140: Fix Failed Simulation Seeds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants