Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unified sender tag #4057

Merged
merged 7 commits into from
Apr 10, 2019
Merged

unified sender tag #4057

merged 7 commits into from
Apr 10, 2019

Conversation

fedekunze
Copy link
Collaborator

Closes #3775

cc: @faboweb @jbibla

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze fedekunze force-pushed the fedekunze/3775-unify-sender-tag branch from 3a9e3ad to c289f64 Compare April 9, 2019 13:54
@fedekunze fedekunze marked this pull request as ready for review April 9, 2019 14:27
@fedekunze fedekunze added T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). ready-for-review labels Apr 9, 2019
@codecov
Copy link

codecov bot commented Apr 9, 2019

Codecov Report

Merging #4057 into develop will decrease coverage by 0.02%.
The diff coverage is 92.85%.

@@             Coverage Diff             @@
##           develop    #4057      +/-   ##
===========================================
- Coverage    59.98%   59.96%   -0.03%     
===========================================
  Files          212      212              
  Lines        15123    15124       +1     
===========================================
- Hits          9072     9069       -3     
- Misses        5431     5435       +4     
  Partials       620      620

@alessio alessio merged commit 8550d87 into develop Apr 10, 2019
@alessio alessio deleted the fedekunze/3775-unify-sender-tag branch April 10, 2019 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants