Fix queryDelegationRewards #4047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
commented
Apr 4, 2019
| @@ -207,7 +207,17 @@ func queryDelegationRewards(ctx sdk.Context, _ []string, req abci.RequestQuery, | |||
| ctx, _ = ctx.CacheContext() | |||
|
|
|||
| val := k.stakingKeeper.Validator(ctx, params.ValidatorAddress) | |||
| if val == nil { | |||
| // TODO: Should use ErrNoValidatorFound from staking/types | |||
There was a problem hiding this comment.
We should be using those error types defined in staking. I see a few options:
- Simply import and use
staking/types - Add alias functions in
distributionwhich are set at runtime by thestakingmodule - Have methods in the
stakingkeeper actually return an appropriate error instead ofnilor abool(i.e.GetValidatorshould return(Validator, sdk.Error/error)instead ofbool)
I'm biased towards (3) as that is the cleanest approach.
Codecov Report
@@ Coverage Diff @@
## release/v0.34.0 #4047 +/- ##
===================================================
- Coverage 59.99% 59.99% -0.01%
===================================================
Files 212 212
Lines 15107 15111 +4
===================================================
+ Hits 9064 9066 +2
Misses 5422 5422
- Partials 621 623 +2 |
alexanderbez
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
jackzampolin
approved these changes
Apr 4, 2019
|
Is this something we want in the release? |
|
Probably we should |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #4020
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
sdkch add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: