Cap Undelegation for Vesting Accounts #3718
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Multi-seed sim failing w/ weird faults: seed 123, 582 (probably the rest): This comes from |
jaekwon
reviewed
Feb 23, 2019
Codecov Report
@@ Coverage Diff @@
## develop #3718 +/- ##
===========================================
+ Coverage 61.15% 61.16% +<.01%
===========================================
Files 190 190
Lines 14008 14009 +1
===========================================
+ Hits 8567 8568 +1
Misses 4905 4905
Partials 536 536 |
alexanderbez
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
alexanderbez
changed the base branch from
cwgoes/debug-vesting-finding
to
develop
|
This seems to be superseded by #3717. |
|
Yeah I guess we can close it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to limit the deduction from
DelegatedVestingby at mostDelegatedVestingduring undelegation, due to the fact that an undelegation amount may exceed the original (vesting) delegation amount./cc @cwgoes @jaekwon @rigelrozanski @zmanian
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added entries in
PENDING.mdwith issue #rereviewed
Files changedin the github PR explorerFor Admin Use: