Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: allow generation of gentxs with empty memo field #3478

Merged
merged 1 commit into from
Feb 2, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Feb 2, 2019

Let gentx generation continue when gaiad is unable to retrieve
machine's external IP and print a warning message.

Closes: #3424

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Let gentx generation continue when gaiad is unable to retrieve
machine's external IP and print a warning message.

Closes: #3424
@alessio alessio changed the title allow generation of gentxs with empty memo field R4R: allow generation of gentxs with empty memo field Feb 2, 2019
@codecov
Copy link

codecov bot commented Feb 2, 2019

Codecov Report

Merging #3478 into develop will decrease coverage by 0.08%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #3478      +/-   ##
===========================================
- Coverage    59.51%   59.42%   -0.09%     
===========================================
  Files          135      135              
  Lines         9981     9982       +1     
===========================================
- Hits          5940     5932       -8     
- Misses        3669     3678       +9     
  Partials       372      372

@jackzampolin jackzampolin merged commit 884ce49 into develop Feb 2, 2019
@alessio alessio deleted the alessio/3424-allow-gentx-with-empty-memo branch February 2, 2019 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants