-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: change --gas=simulate to --gas=auto when sending txs #3170
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3170 +/- ##
===========================================
+ Coverage 54.72% 54.74% +0.02%
===========================================
Files 132 132
Lines 9425 9425
===========================================
+ Hits 5158 5160 +2
+ Misses 3949 3947 -2
Partials 318 318 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @alessio. Left a few comments, lmk your thoughts.
--gas=simulate caused confusion and could be mistaken for the --simulate flag. Closes: #3162
--gas=simulate caused confusion and could be mistaken for the --simulate flag. Closes: #3162 GasFlagSimulate -> GasFlagAuto
--gas=simulate caused confusion and could be mistaken for the --simulate flag. Closes: #3162
51041e0
to
913d8a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for adding the test cases. I deleted them when I changed the gas
type to uint64
but forgot to add them back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK ☕️
--gas=simulate caused confusion and could be
mistaken for the --simulate flag.
Closes: #3162
docs/
)PENDING.md
with issue #Files changed
in the github PR explorerFor Admin Use: