R4R: Fully verify the signature in gaiacli tx sign

[alexanderbez]

Fully verify the signature during gaiacli tx sign --validate-signatures

closes: #2991

---

• Targeted PR against correct branch (see CONTRIBUTING.md)

• Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

• Wrote tests

• Updated relevant documentation (docs/)

• Added entries in PENDING.md with issue #

• rereviewed Files changed in the github PR explorer

---

For Admin Use:

• Added appropriate labels to PR (ex. wip, ready-for-review, docs)
• Reviewers Assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[codecov]

Codecov Report

Merging #2995 into develop will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop   #2995      +/-   ##
==========================================
- Coverage    55.53%   55.5%   -0.03%     
==========================================
  Files          120     120              
  Lines         8494    8494              
==========================================
- Hits          4717    4715       -2     
- Misses        3455    3457       +2     
  Partials       322     322

[jackzampolin]

Pulled locally and working well for me! Also glad we added the logic to actually verify when we say we are. Good PR @alexanderbez

[rigelrozanski]

Let's write a test

[rigelrozanski]

probably a better way which we can avoid creating/using this variable altogether (for another PR though)

[alexanderbez]

@rigelrozanski I'm happy to do that in this PR since it's really in context. Do you have suggestions on how to?

We prefer to loop over all the sigs and not short-circuit. In other words, we cannot simply return an error or bool at first sight of a problem. Any suggestions on how to do this without keeping track via a variable?

[rigelrozanski]

nope, if the point is to complete the loop before returning an error, then a variable must be used. What's the thinking behind completing the loop before returning?

[alexanderbez]

The idea is that txs can have many signers/signatures. The UX we want to provide should show you all the signatures and either an OK or the ERROR. If we short-circuit, the user doesn't get the full picture.

I'd propose the function is ok.

[alexanderbez]

@rigelrozanski @alessio updated.

[alessio]

uACK