Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

organize ADR directory like tendermint's #2693

Merged
merged 2 commits into from
Nov 5, 2018
Merged

organize ADR directory like tendermint's #2693

merged 2 commits into from
Nov 5, 2018

Conversation

zramsay
Copy link
Contributor

@zramsay zramsay commented Nov 5, 2018

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@zramsay zramsay requested a review from gamarin2 November 5, 2018 15:11
gamarin2
gamarin2 reviewed Nov 5, 2018
View reviewed changes
docs/architecture/adr-template.md Outdated
@@ -0,0 +1,19 @@
# ADR 000: Template for an ADR
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel the old version of this file is better no? Same architecture with more comments

Copy link
Contributor

@alexanderbez alexanderbez Nov 5, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to agree here (not biased as I wrote it :-p)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll switch it back and sync the other way with tendermint

@codecov
Copy link

codecov bot commented Nov 5, 2018

Codecov Report

Merging #2693 into docs-overhaul will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           docs-overhaul    #2693   +/-   ##
==============================================
  Coverage          58.01%   58.01%           
==============================================
  Files                153      153           
  Lines               9511     9511           
==============================================
  Hits                5518     5518           
  Misses              3632     3632           
  Partials             361      361

alexanderbez
alexanderbez approved these changes Nov 5, 2018
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 👍

cwgoes
cwgoes approved these changes Nov 5, 2018
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@zramsay zramsay merged commit 300b74a into docs-overhaul Nov 5, 2018
@zramsay zramsay deleted the fix-adr-structure branch November 5, 2018 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gamarin2 gamarin2 gamarin2 left review comments

@alexanderbez alexanderbez alexanderbez approved these changes

@cwgoes cwgoes cwgoes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zramsay @alexanderbez @gamarin2 @cwgoes