Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sequence should be higher or equal than expected during checktx and equal during deliver tx (backport #22299) #22307

Open
wants to merge 1 commit into
base: release/v0.52.x
Choose a base branch
from
Open

fix: sequence should be higher or equal than expected during checktx and equal during deliver tx (backport #22299) #22307

wants to merge 1 commit into from
+37 −22

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 17, 2024

Description

This is a QOL change where TX sequence will be expected to be higher equal than sequence during checktx, and equal during deliver tx.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:

  • confirmed ! in the type prefix if API or client breaking change

  • targeted the correct branch (see PR Targeting)

  • provided a link to the relevant issue or specification

  • reviewed "Files changed" and left comments if necessary

  • included the necessary unit and integration tests

  • added a changelog entry to CHANGELOG.md

  • updated the relevant documentation or specification, including comments for documenting Go code

  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • New Features

    • Enhanced account structure to support transaction functionalities.
    • Improved signature verification logic with execution mode handling.
    • Expanded test coverage for transaction simulation, error handling, and signature verification.

  • Bug Fixes

    • Clarified error messages for sequence mismatches during signature verification.

  • Refactor

    • Simplified logic in transaction signing and broadcasting tests for better uniformity.
This is an automatic backport of pull request #22299 done by [Mergify](https://mergify.com).

@testinginprod @mergify
fix: sequence should be higher or equal than expected during checktx …
6e7643a 
…and equal during deliver tx (#22299)

Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Matt Kocubinski <mkocubinski@gmail.com>
(cherry picked from commit c1707b8)
@mergify mergify bot requested a review from a team as a code owner October 17, 2024 15:52
@github-actions GitHub Actions
Copy link
Contributor

@mergify[bot] your pull request is missing a changelog!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C:x/accounts/base C:x/accounts C:x/auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@testinginprod