R4R: fix Iterator leak, see #2105 #2107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goolAdapter
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
goolAdapter
changed the title
|
the develop branch is broken before this pr, make test_cli can’t pass. |
|
@goolAdapter Thanks ! Can you add the entry of the bug to |
|
@goolAdapter yes -- we're pausing any merges to |
This is done, rebase on develop and you should be good to go (also likely will fix CI). |
ValarDragon
approved these changes
Aug 21, 2018
chillyvee
pushed a commit
to chillyvee/cosmos-sdk
that referenced
this pull request
Mar 1, 2024
* docs: bypass msg * docs: update globalfee docs * docs: formatting * Update globalfee.md * docs: fix link * docs: min_gas_prices -> minimum-gas-prices * docs: Updating globalfee docs (cosmos#2107) * add maxBypassMinFeeMsgGasUsage var and docstring * improve docstring in FeeDecorator.AnteHandle * updating docs * refactor globalfee documentation * refactor docs * fix typo * Update x/globalfee/ante/fee.go Co-authored-by: MSalopek <35486649+MSalopek@users.noreply.github.com> --------- Co-authored-by: Matija Salopek <matija.salopek994@gmail.com> Co-authored-by: MSalopek <35486649+MSalopek@users.noreply.github.com> * docs: update globalfee doc * cleanup examples --------- Co-authored-by: Marius Poke <marius.poke@posteo.de> Co-authored-by: Matija Salopek <matija.salopek994@gmail.com> Co-authored-by: MSalopek <35486649+MSalopek@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…/2105
fix Iterator leak, see #2105
Closes #2105
docs/)PENDING.mdthat include links to the relevant issue or PR that most accurately describes the change.cmd/gaiaandexamples/For Admin Use: