Update PR template for release process #2041
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2041 +/- ##
========================================
Coverage 64.86% 64.86%
========================================
Files 115 115
Lines 6862 6862
========================================
Hits 4451 4451
Misses 2127 2127
Partials 284 284 |
There was a problem hiding this comment.
I think this is too verbose to add into the PR template (4 lines for one concept is a lot) - I think this should instead be added to CONTRIBUTING.md. Maybe having just the first line Targeted PR against correct branch and have it linked to the section in CONTRIBUTING could make sense
OK; so updated. |
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| @@ -4,6 +4,11 @@ v Before smashing the submit button please review the checkboxes. | |||
| v If a checkbox is n/a - please still include it but + a little note why | |||
| ☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --> | |||
|
|
|||
| - Targeted PR against correct branch: | |||
| - `release/vxx.yy.zz` for a merge into a release candidate | |||
There was a problem hiding this comment.
If we're going to list this in the pr template we should give more direction as to what prs go into the release. If we don't, then this shouldn't go in the template imo
| ### PR Targeting | ||
|
|
||
| Ensure that you base and target your PR on the correct branch: | ||
| - `release/vxx.yy.zz` for a merge into a release candidate |
There was a problem hiding this comment.
If we're going to list this in the CONTRIBUTING.md we should give more direction as to what prs go into the release. Right now this basically just states what the main branches are, not which PR's should go where.
There was a problem hiding this comment.
Added a paragraph to explain which PRs should go where.
* Upgrade to v9 * Update handler * Fix linter * Remove old or basic upgrades from codecov * add execute rights to test scripts (cosmos#2041) * Add e2e tests * Update code smell * Remove and refactor duplicated query exec * Fix linter * Update ICS dependency * Update dependency * Fix typo Co-authored-by: Simon Noetzlin <simon.ntz@gmail.com> Co-authored-by: MSalopek <35486649+MSalopek@users.noreply.github.com> Co-authored-by: Simon Noetzlin <simon.ntz@gmail.com>
For Admin Use: